-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge OBC package from Buildings to IBPSA #1946
Conversation
This function is used in various CDL Elementary Blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwetter I will look into the CDL package in the upcoming days, just noticed a minor naming issue outside of that package.
Aside from that comment, the documentation and naming looks ok. Otherwise, I only have two requests:
|
@FWuellhorst : Thanks for the review. The two points above have been addressed. Can you please review and approve it all is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UserGuide is clear and concise, and the models all look good.
This closes #1944
It also moves the
round
function in the math package as it is used in various Elementary Blocks, and it moves some Composite Control blocks that are likely of general interest.